Init overview page #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use a stack elements in the vertical or horizontal direction - create separate components for icons - add `currencies.ts` file
- add a toggle button to switch the currency - add a button to the documentation
kkosiorowska
force-pushed
the
init-overview-page
branch
from
fc4bd5b to
2781325
Compare
The Stack component and the Flex component have their children spaced out evenly but the key difference is that the Stack won't span the entire width of the container whereas the Flex will. Let's use the Stack component when it is a simple row or column of items. If we need to customize the items let's use Flex. More info: https://chakra-ui.com/docs/components/stack#notes-on-stack-vs-flex
kkosiorowska
force-pushed
the
init-overview-page
branch
from
2781325 to
5260526
Compare
Closed
r-czajkowski
requested changes
Dec 5, 2023
kkosiorowska
force-pushed
the
init-overview-page
branch
from
0231229 to
2dca2bf
Compare
`createIcon` add the svg tag by default. Let's remove the unnecessary extra tag.
r-czajkowski
requested changes
Dec 7, 2023
r-czajkowski
requested changes
Dec 8, 2023
By `CardProps` we can avoid unnecessary wrappers in grid and control content from the parent component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits the site into 3 main elements: position details pool stats and transaction history. The page split should make it easier to work on the separate elements of the page. The size and positioning of elements may change. Please don't pay more attention to styles. These also change dynamically and typography or colors are not defined yet. The purpose of this PR is to define only the separate components. Fixes to the styles will be done in the next steps.
What has been done
createIconfunction to use the dedicatedIconcomponent from Chakra UI. This will allow us to easily change the color of our icons depending on the situation. This is possible by using thecurrentColorvalue for thesvg.currencies.tsVStack,HStackandFlex- Let's use theStackcomponent when it is a simple row or column of items. If we need to customize the items let's use Flex.UI